From f9195583cfbeb3310ebc2cf93749bd6e8f977980 Mon Sep 17 00:00:00 2001 From: "danborkmann@iogearbox.net" Date: Mon, 10 Oct 2011 06:52:46 +0000 Subject: [PATCH] af_packet: remove unnecessary BUG_ON() in tpacket_destruct_skb If skb is NULL, then stack trace is thrown anyway on dereference. Therefore, the stack trace triggered by BUG_ON is duplicate. Signed-off-by: Daniel Borkmann Cc: Eric Dumazet Acked-by: Eric Dumazet Signed-off-by: David S. Miller --- net/packet/af_packet.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index dac91abf4c0fb..7b5f03253016c 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -1968,8 +1968,6 @@ static void tpacket_destruct_skb(struct sk_buff *skb) struct packet_sock *po = pkt_sk(skb->sk); void *ph; - BUG_ON(skb == NULL); - if (likely(po->tx_ring.pg_vec)) { ph = skb_shinfo(skb)->destructor_arg; BUG_ON(__packet_get_status(po, ph) != TP_STATUS_SENDING); -- 2.39.5