From f8047e1bb4e0c0cd8cafa684ab0a5091e1ee9cf2 Mon Sep 17 00:00:00 2001 From: Liviu Dudau Date: Thu, 18 Oct 2018 01:14:32 +0100 Subject: [PATCH] leds: gpio: set led_dat->gpiod pointer for OF defined GPIO leds Commit cad631f834c6 ("leds: gpio: Try to lookup gpiod from device") removed the common code path that set the led_dat->gpiod pointer in create_gpio_led(), but only added it back for the devices that have a valid gpio_led_platform_data structure. Calling gpio_leds_create() in gpio_led_probe() is not enough to get a valid gpiod pointer. Fortunately enough, gpio_leds_create() already gets the needed pointer, we just need to assign it to the relevant gpio_led_data structure. Fixes: cad631f834c6 ("leds: gpio: Try to lookup gpiod from device") Signed-off-by: Liviu Dudau Reviewed-by: Linus Walleij Acked-by: Pavel Machek Signed-off-by: Jacek Anaszewski --- drivers/leds/leds-gpio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index 32fa752565bc9..45e0120938658 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -163,6 +163,8 @@ static struct gpio_leds_priv *gpio_leds_create(struct platform_device *pdev) return ERR_CAST(led.gpiod); } + led_dat->gpiod = led.gpiod; + fwnode_property_read_string(child, "linux,default-trigger", &led.default_trigger); -- 2.39.5