From ecd97472eb6d06ef1a963084e13e79cff94b7ca6 Mon Sep 17 00:00:00 2001 From: Jakub Kicinski Date: Thu, 6 Jul 2017 17:29:05 -0700 Subject: [PATCH] nfp: flower: add missing clean up call to avoid memory leaks nfp_flower_metadata_cleanup() is defined but never invoked, not calling it will cause us to leak mask and statistics queue memory on the host. Fixes: 6524b0b3bcc4 ("nfp: add metadata to each flow offload") Signed-off-by: Jakub Kicinski Signed-off-by: David S. Miller --- drivers/net/ethernet/netronome/nfp/flower/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.c b/drivers/net/ethernet/netronome/nfp/flower/main.c index fc10f27e0a0ca..6a65c8b33807c 100644 --- a/drivers/net/ethernet/netronome/nfp/flower/main.c +++ b/drivers/net/ethernet/netronome/nfp/flower/main.c @@ -356,6 +356,7 @@ err_free_app_priv: static void nfp_flower_clean(struct nfp_app *app) { + nfp_flower_metadata_cleanup(app); vfree(app->priv); app->priv = NULL; } -- 2.39.5