From e3d8779e06e54af94185e0b629dac84eaf6edede Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Wed, 29 Jul 2020 23:59:14 +0800 Subject: [PATCH] platform/x86: thinkpad_acpi: Make some symbols static The sparse tool complains as follows: drivers/platform/x86/thinkpad_acpi.c:9636:25: warning: symbol 'dev_attr_charge_start_threshold' was not declared. Should it be static? drivers/platform/x86/thinkpad_acpi.c:9642:25: warning: symbol 'dev_attr_charge_stop_threshold' was not declared. Should it be static? Those variables are not used outside of thinkpad_acpi.c, so this commit marks them static. Fixes: db5e2e26be91 ("platform/x86: thinkpad_acpi: use standard charge control attribute names") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun Signed-off-by: Andy Shevchenko --- drivers/platform/x86/thinkpad_acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 9eda2f84a3cf9..4864a5c189d46 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -9633,13 +9633,13 @@ static ssize_t charge_control_end_threshold_store(struct device *dev, static DEVICE_ATTR_RW(charge_control_start_threshold); static DEVICE_ATTR_RW(charge_control_end_threshold); -struct device_attribute dev_attr_charge_start_threshold = __ATTR( +static struct device_attribute dev_attr_charge_start_threshold = __ATTR( charge_start_threshold, 0644, charge_control_start_threshold_show, charge_control_start_threshold_store ); -struct device_attribute dev_attr_charge_stop_threshold = __ATTR( +static struct device_attribute dev_attr_charge_stop_threshold = __ATTR( charge_stop_threshold, 0644, charge_control_end_threshold_show, -- 2.39.5