From e11aa590395e4cf17b80971a0b6ab204289f2edd Mon Sep 17 00:00:00 2001
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 23 May 2016 13:21:01 +0300
Subject: [PATCH] NFS: checking for NULL instead of IS_ERR() in
nfs_commit_file()
nfs_create_request() doesn't return NULL, it returns error pointers.
Fixes: 36bf160df5db ('NFS: Add nfs_commit_file()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
---
fs/nfs/write.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index 4dac51ba1f7ea..54a4eb6bc4629 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -1735,8 +1735,8 @@ int nfs_commit_file(struct file *file, struct nfs_write_verifier *verf)
open = get_nfs_open_context(nfs_file_open_context(file));
req = nfs_create_request(open, NULL, NULL, 0, i_size_read(inode));
- if (!req) {
- ret = -ENOMEM;
+ if (IS_ERR(req)) {
+ ret = PTR_ERR(req);
goto out_put;
}
--
2.39.5