From d92d44b91488c763737ff21ea8f72a09020fd17c Mon Sep 17 00:00:00 2001 From: Mateusz Nosek Date: Mon, 6 Apr 2020 20:08:49 -0700 Subject: [PATCH] mm/dmapool.c: micro-optimisation remove unnecessary branch Previously there was a check if 'size' is aligned to 'align' and if not then it was aligned. This check was expensive as both branch and division are expensive instructions in most architectures. 'ALIGN' function on already aligned value will not change it, and as it is cheaper than branch + division it can be executed all the time and branch can be removed. Signed-off-by: Mateusz Nosek Signed-off-by: Andrew Morton Reviewed-by: Andrew Morton Link: http://lkml.kernel.org/r/20200320173317.26408-1-mateusznosek0@gmail.com Signed-off-by: Linus Torvalds --- mm/dmapool.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index fe5d33060415b..f9fb9bbd733e0 100644 --- a/mm/dmapool.c +++ b/mm/dmapool.c @@ -144,9 +144,7 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev, else if (size < 4) size = 4; - if ((size % align) != 0) - size = ALIGN(size, align); - + size = ALIGN(size, align); allocation = max_t(size_t, size, PAGE_SIZE); if (!boundary) -- 2.39.5