From d87a89386db07f43319e642b16f727f88e46dc5b Mon Sep 17 00:00:00 2001 From: Marek Vasut Date: Sat, 11 Mar 2023 17:29:21 +0100 Subject: [PATCH] cmd: fdt: Use env_set_hex() for "get addr" and "get size" The 'fdt get addr' and 'env get size' is always assumed to be hex value, drop the prefix, and outright switch to env_set_hex(). Since this might break existing users who depend on the existing behavior with 0x prefix, this is a separate patch. Revert if this breaks anything. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- cmd/fdt.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/cmd/fdt.c b/cmd/fdt.c index 04b664e652..87d9a38507 100644 --- a/cmd/fdt.c +++ b/cmd/fdt.c @@ -475,18 +475,9 @@ static int do_fdt(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) if (ret != 0) return ret; } else if (subcmd[0] == 'a') { - /* Get address */ - char buf[19]; - - snprintf(buf, sizeof(buf), "%lx", - (ulong)map_to_sysmem(nodep)); - env_set(var, buf); + env_set_hex(var, (ulong)map_to_sysmem(nodep)); } else if (subcmd[0] == 's') { - /* Get size */ - char buf[11]; - - sprintf(buf, "0x%08X", len); - env_set(var, buf); + env_set_hex(var, len); } else return CMD_RET_USAGE; return 0; -- 2.39.5