From d1e1b05b1f1eb632ef218cdf382137b921cffe62 Mon Sep 17 00:00:00 2001 From: Eric Dumazet Date: Fri, 8 Jul 2022 16:28:58 +0000 Subject: [PATCH] af_unix: fix unix_sysctl_register() error path We want to kfree(table) if @table has been kmalloced, ie for non initial network namespace. Fixes: cfdf57906d9a ("af_unix: Do not call kmemdup() for init_net's sysctl table.") Signed-off-by: Eric Dumazet Cc: Kuniyuki Iwashima Cc: Eric W. Biederman Acked-by: Kuniyuki Iwashima Signed-off-by: David S. Miller --- net/unix/sysctl_net_unix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/unix/sysctl_net_unix.c b/net/unix/sysctl_net_unix.c index 3f1fdffd6092c..500129aa710c7 100644 --- a/net/unix/sysctl_net_unix.c +++ b/net/unix/sysctl_net_unix.c @@ -43,7 +43,7 @@ int __net_init unix_sysctl_register(struct net *net) return 0; err_reg: - if (net_eq(net, &init_net)) + if (!net_eq(net, &init_net)) kfree(table); err_alloc: return -ENOMEM; -- 2.39.5