From 94c9c5c52d88d493d6d2a7edd512650a5a6615b3 Mon Sep 17 00:00:00 2001 From: Alex Deucher Date: Mon, 30 Nov 2020 18:36:41 -0500 Subject: [PATCH] drm/amdgpu/powerplay/iceland: return an error if copying to smc fails Rather than just silently dropping it. Also fixes a set but unused variable warning. Reviewed-by: Evan Quan Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c b/drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c index 6a0f581de999b..03df35dee8ba8 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c @@ -2156,7 +2156,7 @@ static int iceland_thermal_setup_fan_table(struct pp_hwmgr *hwmgr) res = smu7_copy_bytes_to_smc(hwmgr, smu7_data->fan_table_start, (uint8_t *)&fan_table, (uint32_t)sizeof(fan_table), SMC_RAM_END); - return 0; + return res; } -- 2.39.5