From 93ba0273ff3dc0fa97b2623307f1fb78a1585afd Mon Sep 17 00:00:00 2001 From: Pavel Machek Date: Mon, 3 Aug 2020 14:00:06 +0200 Subject: [PATCH] leds: disallow /sys/class/leds/*:multi:* for now All the LEDs in the queue are RGB, so they should not use multi for their color. Make sure we don't add such LED by mistake (and make it part of ABI). Signed-off-by: Pavel Machek --- drivers/leds/led-core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c index a6dce01dbd5ea..c4e780bdb3852 100644 --- a/drivers/leds/led-core.c +++ b/drivers/leds/led-core.c @@ -425,6 +425,10 @@ int led_compose_name(struct device *dev, struct led_init_data *init_data, struct fwnode_handle *fwnode = init_data->fwnode; const char *devicename = init_data->devicename; + /* We want to label LEDs that can produce full range of colors + * as RGB, not multicolor */ + BUG_ON(props.color == LED_COLOR_ID_MULTI); + if (!led_classdev_name) return -EINVAL; -- 2.39.5