From 8a6d7a0b4437df0001d30a010c8a8a697b05a862 Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Wed, 11 Jan 2017 16:32:51 +0000 Subject: [PATCH] net: thunderx: Fix error return code in nicvf_open() Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: f47d8007bb44 ("net: thunderx: Program LMAC credits based on MTU") Signed-off-by: Wei Yongjun Signed-off-by: David S. Miller --- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_main.c b/drivers/net/ethernet/cavium/thunder/nicvf_main.c index 273eafdb1c575..a25bb6ea2ff44 100644 --- a/drivers/net/ethernet/cavium/thunder/nicvf_main.c +++ b/drivers/net/ethernet/cavium/thunder/nicvf_main.c @@ -1274,7 +1274,8 @@ int nicvf_open(struct net_device *netdev) /* Configure receive side scaling and MTU */ if (!nic->sqs_mode) { nicvf_rss_init(nic); - if (nicvf_update_hw_max_frs(nic, netdev->mtu)) + err = nicvf_update_hw_max_frs(nic, netdev->mtu); + if (err) goto cleanup; /* Clear percpu stats */ -- 2.39.5