From 7ee8535de5463e8b64725866001a78ac4c9ba3c8 Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Mon, 18 May 2015 08:59:12 +0200
Subject: [PATCH] ALSA: info: Fix leaks of child entries at
snd_info_free_entry()
snd_info_free_entry() releases the all children nodes as well, but due
to the wrong timing of releasing the link, the children nodes may be
disconnected but left unreleased. This patch fixes it by moving the
link free at the right position. Also it eases list_for_each_entry()
without _safe option in snd_info_disconnect() because it no longer
frees the children nodes there.
Fixes: f76176670797 ('ALSA: core: Remove child proc file elements recursively')
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/core/info.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/core/info.c b/sound/core/info.c
index c8a413d6cc9b5..5662793746838 100644
--- a/sound/core/info.c
+++ b/sound/core/info.c
@@ -738,13 +738,12 @@ EXPORT_SYMBOL(snd_info_create_card_entry);
static void snd_info_disconnect(struct snd_info_entry *entry)
{
- struct snd_info_entry *p, *n;
+ struct snd_info_entry *p;
if (!entry->p)
return;
- list_for_each_entry_safe(p, n, &entry->children, list)
+ list_for_each_entry(p, &entry->children, list)
snd_info_disconnect(p);
- list_del_init(&entry->list);
proc_remove(entry->p);
entry->p = NULL;
}
@@ -771,6 +770,7 @@ void snd_info_free_entry(struct snd_info_entry * entry)
list_for_each_entry_safe(p, n, &entry->children, list)
snd_info_free_entry(p);
+ list_del(&entry->list);
kfree(entry->name);
if (entry->private_free)
entry->private_free(entry);
--
2.39.5