From 6c8e0af17a7e27eb41c53e8405316e44859099cf Mon Sep 17 00:00:00 2001 From: Andy Shevchenko Date: Sat, 11 Jul 2020 16:53:42 +0300 Subject: [PATCH] Revert "serial: sunhv: Initialize lock for non-registered console" This reverts commit 8d79f161621930d4372dcd1072fa6a4c8cd2ba8a. There has been a quick fix against uninitialised lock revealed by the commit c1964b873471 ("serial: core: Initialise spin lock before use in uart_configure_port()"). Since we have now better fix in serial core, this may be safely reverted. Fixes: 8d79f1616219 ("serial: sunhv: Initialize lock for non-registered console") Depends-on: c1964b873471 ("serial: core: Initialise spin lock before use in uart_configure_port()") Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20200711135346.71171-1-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/sunhv.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/tty/serial/sunhv.c b/drivers/tty/serial/sunhv.c index e35073e93a5b4..eafada8fb6fad 100644 --- a/drivers/tty/serial/sunhv.c +++ b/drivers/tty/serial/sunhv.c @@ -567,9 +567,6 @@ static int hv_probe(struct platform_device *op) sunserial_console_match(&sunhv_console, op->dev.of_node, &sunhv_reg, port->line, false); - /* We need to initialize lock even for non-registered console */ - spin_lock_init(&port->lock); - err = uart_add_one_port(&sunhv_reg, port); if (err) goto out_unregister_driver; -- 2.39.5