From 3e3811461683b18b843a2868254f5862acd0a679 Mon Sep 17 00:00:00 2001 From: Yang Yingliang Date: Thu, 30 Jun 2022 09:41:53 +0800 Subject: [PATCH] net: dsa: rzn1-a5psw: add missing of_node_put() in a5psw_pcs_get() of_parse_phandle() will increase the refcount of 'pcs_node', so add of_node_put() before return from a5psw_pcs_get(). Fixes: e9fc4f921b1b ("net: dsa: rzn1-a5psw: add Renesas RZ/N1 advanced 5 port switch driver") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220630014153.1888811-1-yangyingliang@huawei.com Signed-off-by: Jakub Kicinski --- drivers/net/dsa/rzn1_a5psw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c index 5b14e2ba9b79a..0744e8162e1d5 100644 --- a/drivers/net/dsa/rzn1_a5psw.c +++ b/drivers/net/dsa/rzn1_a5psw.c @@ -917,12 +917,14 @@ static int a5psw_pcs_get(struct a5psw *a5psw) } a5psw->pcs[reg] = pcs; + of_node_put(pcs_node); } of_node_put(ports); return 0; free_pcs: + of_node_put(pcs_node); of_node_put(port); of_node_put(ports); a5psw_pcs_free(a5psw); -- 2.39.5