From 01a678d4d67aba857f9e2b36288c1f93773b3c26 Mon Sep 17 00:00:00 2001 From: Josef Bacik Date: Mon, 16 Jul 2018 12:12:23 -0400 Subject: [PATCH] blk-iolatency: truncate our current time In our longer tests we noticed that some boxes would degrade to the point of uselessness. This is because we truncate the current time when saving it in our bio, but I was using the raw current time to subtract from. So once the box had been up a certain amount of time it would appear as if our IO's were taking several years to complete. Fix this by truncating the current time so it matches the issue time. Verified this worked by running with this patch for a week on our test tier. Signed-off-by: Josef Bacik Signed-off-by: Jens Axboe --- block/blk-iolatency.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c index 893f888eebb1a..bb59b2929e0d9 100644 --- a/block/blk-iolatency.c +++ b/block/blk-iolatency.c @@ -425,6 +425,12 @@ static void iolatency_record_time(struct iolatency_grp *iolat, u64 start = bio_issue_time(issue); u64 req_time; + /* + * Have to do this so we are truncated to the correct time that our + * issue is truncated to. + */ + now = __bio_issue_time(now); + if (now <= start) return; -- 2.39.5