]> git.baikalelectronics.ru Git - kernel.git/commit
tipc: use consistent GFP flags
authorTadeusz Struk <tadeusz.struk@linaro.org>
Thu, 11 Nov 2021 20:59:16 +0000 (12:59 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Nov 2021 12:57:31 +0000 (12:57 +0000)
commitf8c0666ca03136b503853b0e4b823a0f1d113bd6
tree9cc4ea9af1ca1424789d893353d2efc47b38be58
parent003fbfff5d88341f631bc926efa665dcee2bbd7b
tipc: use consistent GFP flags

Some functions, like tipc_crypto_start use inconsisten GFP flags
when allocating memory. The mentioned function use GFP_ATOMIC to
to alloc a crypto instance, and then calls alloc_ordered_workqueue()
which allocates memory with GFP_KERNEL. tipc_aead_init() function
even uses GFP_KERNEL and GFP_ATOMIC interchangeably.
No doc comment specifies what context a function is designed to
work in, but the flags should at least be consistent within a function.

Cc: Jon Maloy <jmaloy@redhat.com>
Cc: Ying Xue <ying.xue@windriver.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Cc: tipc-discussion@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Tadeusz Struk <tadeusz.struk@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/crypto.c