]> git.baikalelectronics.ru Git - kernel.git/commit
arm64: ftrace: Define ftrace_stub_graph only with FUNCTION_GRAPH_TRACER
authorSami Tolvanen <samitolvanen@google.com>
Wed, 9 Nov 2022 19:28:31 +0000 (19:28 +0000)
committerCatalin Marinas <catalin.marinas@arm.com>
Mon, 14 Nov 2022 12:28:52 +0000 (12:28 +0000)
commitf000be353582beadae7182b7817cb73014da72b9
tree84615da571362fa92aa9da754e87dab0b5711942
parentdfd2bf0335fb2bf3195544c775fab6f0b6e2f418
arm64: ftrace: Define ftrace_stub_graph only with FUNCTION_GRAPH_TRACER

The 0-day bot reports that arm64 builds with CONFIG_CFI_CLANG +
CONFIG_FTRACE are broken when CONFIG_FUNCTION_GRAPH_TRACER is not
enabled:

 ld.lld: error: undefined symbol: __kcfi_typeid_ftrace_stub_graph
 >>> referenced by entry-ftrace.S:299 (arch/arm64/kernel/entry-ftrace.S:299)
 >>>               arch/arm64/kernel/entry-ftrace.o:(.text+0x48) in archive vmlinux.a

This is caused by ftrace_stub_graph using SYM_TYPE_FUNC_START when
the address of the function is not taken in any C translation unit.

Fix the build by only defining ftrace_stub_graph when it's actually
needed, i.e. with CONFIG_FUNCTION_GRAPH_TRACER.

Link: https://lore.kernel.org/lkml/202210251659.tRMs78RH-lkp@intel.com/
Fixes: d57125345156 ("ftrace,kcfi: Separate ftrace_stub() and ftrace_stub_graph()")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Link: https://lore.kernel.org/r/20221109192831.3057131-1-samitolvanen@google.com
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/kernel/entry-ftrace.S