]> git.baikalelectronics.ru Git - kernel.git/commit
bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify
authorRoopa Prabhu <roopa@cumulusnetworks.com>
Thu, 29 Jan 2015 00:23:11 +0000 (16:23 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 29 Jan 2015 06:21:31 +0000 (22:21 -0800)
commite83d3d0e314c0b8c86f9937c67bbb816cadadb18
tree764a66a697481a65f8d16ab7277dede72642b187
parent73684df01cb6c71b78d3baba3c5959672986101f
bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify

Reported in: https://bugzilla.kernel.org/show_bug.cgi?id=92081

This patch avoids calling rtnl_notify if the device ndo_bridge_getlink
handler does not return any bytes in the skb.

Alternately, the skb->len check can be moved inside rtnl_notify.

For the bridge vlan case described in 92081, there is also a fix needed
in bridge driver to generate a proper notification. Will fix that in
subsequent patch.

v2: rebase patch on net tree

Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c