]> git.baikalelectronics.ru Git - kernel.git/commit
oom: fix the unsafe usage of badness() in proc_oom_score()
authorOleg Nesterov <oleg@redhat.com>
Thu, 1 Apr 2010 13:13:57 +0000 (15:13 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 1 Apr 2010 15:50:21 +0000 (08:50 -0700)
commite62296f0b7170035e119fc6b96db14891e5ea6c1
tree9584cf21e47baec986f5dc5455081e8538126be1
parent32f01e4810e891804172b22fa09d02073bb58485
oom: fix the unsafe usage of badness() in proc_oom_score()

proc_oom_score(task) has a reference to task_struct, but that is all.
If this task was already released before we take tasklist_lock

- we can't use task->group_leader, it points to nowhere

- it is not safe to call badness() even if this task is
  ->group_leader, has_intersects_mems_allowed() assumes
  it is safe to iterate over ->thread_group list.

- even worse, badness() can hit ->signal == NULL

Add the pid_alive() check to ensure __unhash_process() was not called.

Also, use "task" instead of task->group_leader. badness() should return
the same result for any sub-thread. Currently this is not true, but
this should be changed anyway.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/proc/base.c