]> git.baikalelectronics.ru Git - kernel.git/commit
NFSv4: Fix deadlock between nfs4_evict_inode() and nfs4_opendata_get_inode()
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Tue, 1 Jun 2021 15:10:05 +0000 (11:10 -0400)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Thu, 3 Jun 2021 14:14:42 +0000 (10:14 -0400)
commite4abb4a0415efb890536227f89ff565e0034789e
tree2a74d5f01498891b11d85c89085737df12838413
parenta1a2db6a474edbf6e8dab9eeaf2efa7cade13d6a
NFSv4: Fix deadlock between nfs4_evict_inode() and nfs4_opendata_get_inode()

If the inode is being evicted, but has to return a delegation first,
then it can cause a deadlock in the corner case where the server reboots
before the delegreturn completes, but while the call to iget5_locked() in
nfs4_opendata_get_inode() is waiting for the inode free to complete.
Since the open call still holds a session slot, the reboot recovery
cannot proceed.

In order to break the logjam, we can turn the delegation return into a
privileged operation for the case where we're evicting the inode. We
know that in that case, there can be no other state recovery operation
that conflicts.

Reported-by: zhangxiaoxu (A) <zhangxiaoxu5@huawei.com>
Fixes: 348fe89b656b ("NFSv4: Return delegations synchronously in evict_inode")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/nfs4_fs.h
fs/nfs/nfs4proc.c