]> git.baikalelectronics.ru Git - kernel.git/commit
tcp: Do not apply TSO segment limit to non-TSO packets
authorHerbert Xu <herbert@gondor.apana.org.au>
Wed, 31 Dec 2014 13:39:23 +0000 (00:39 +1100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 2 Jan 2015 21:13:20 +0000 (16:13 -0500)
commitdc755452999af98196ec91a61605e4e9f2e5274c
tree530f87ef25fccc495166de5a2e520e4e94871f9a
parent3b22d04d00687afc198a435157bfc6fc4653cd75
tcp: Do not apply TSO segment limit to non-TSO packets

Thomas Jarosch reported IPsec TCP stalls when a PMTU event occurs.

In fact the problem was completely unrelated to IPsec.  The bug is
also reproducible if you just disable TSO/GSO.

The problem is that when the MSS goes down, existing queued packet
on the TX queue that have not been transmitted yet all look like
TSO packets and get treated as such.

This then triggers a bug where tcp_mss_split_point tells us to
generate a zero-sized packet on the TX queue.  Once that happens
we're screwed because the zero-sized packet can never be removed
by ACKs.

Fixes: 464b9182e11 ("tcp: Apply device TSO segment limit earlier")
Reported-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Cheers,
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_output.c