]> git.baikalelectronics.ru Git - kernel.git/commit
checkpatch: kconfig: prefer 'help' over '---help---'
authorUlf Magnusson <ulfalizer@gmail.com>
Fri, 16 Feb 2018 20:22:55 +0000 (21:22 +0100)
committerMasahiro Yamada <yamada.masahiro@socionext.com>
Sun, 25 Mar 2018 17:03:57 +0000 (02:03 +0900)
commitd0ebe97b779f5b22dd489d4c42841d2c67b03861
treebc79978850d383622c75f5beafc7425c4bef4cda
parentd29e6df9588b57b092afc7b5076e72f7f698b772
checkpatch: kconfig: prefer 'help' over '---help---'

IMO, we should discourage '---help---' for new help texts, even in cases
where it would be consistent with other help texts in the file. This
will help if we ever want to get rid of '---help---' in the future.

Also simplify the code to only check for exactly '---help---'. Since
commit 87eeb101ed31 ("kconfig: warn of unhandled characters in Kconfig
commands"), '---help---' is a proper keyword and can only appear in that
form. Prior to that commit, '---help---' working was more of a syntactic
quirk.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/checkpatch.pl