]> git.baikalelectronics.ru Git - kernel.git/commit
net: mvneta: Fix an out of bounds check
authorDan Carpenter <error27@gmail.com>
Wed, 7 Dec 2022 07:06:31 +0000 (10:06 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 8 Dec 2022 17:09:36 +0000 (09:09 -0800)
commitcdd97383e19d4afe29adc3376025a15ae3bab3a3
tree5824da88d36abdff7cfc02cc62e072dbc4daf094
parented14e5903638f6eb868e3e2b4e610985e6a6c876
net: mvneta: Fix an out of bounds check

In an earlier commit, I added a bounds check to prevent an out of bounds
read and a WARN().  On further discussion and consideration that check
was probably too aggressive.  Instead of returning -EINVAL, a better fix
would be to just prevent the out of bounds read but continue the process.

Background: The value of "pp->rxq_def" is a number between 0-7 by default,
or even higher depending on the value of "rxq_number", which is a module
parameter. If the value is more than the number of available CPUs then
it will trigger the WARN() in cpu_max_bits_warn().

Fixes: e8b4fc13900b ("net: mvneta: Prevent out of bounds read in mvneta_config_rss()")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/Y5A7d1E5ccwHTYPf@kadam
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/mvneta.c