]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Enable -Wuninitialized
authorNathan Chancellor <nathan@kernel.org>
Tue, 16 Feb 2021 21:29:54 +0000 (14:29 -0700)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 17 Feb 2021 14:16:21 +0000 (14:16 +0000)
commitbdbff7e2f975aa4c450d5ef7fcb3719a76094c7d
treeecc034ad9c049e4527c9ced2ce84c91a01fcc9ab
parent07927798646e47542b0c7a3394cc77defea671c7
drm/i915: Enable -Wuninitialized

-Wunintialized was disabled in commit 7ad6b09f2247 ("drm/i915: Disable
-Wuninitialized") because there were two warnings that were false
positives. The first was due to DECLARE_WAIT_QUEUE_HEAD_ONSTACK, which
was fixed in LLVM 9.0.0. The second was in busywait_stop, which was
fixed in LLVM 10.0.0 (issue 415). The kernel's minimum version for LLVM
is 10.0.1 so this warning can be safely enabled, where it has already
caught a couple bugs.

Link: https://github.com/ClangBuiltLinux/linux/issues/220
Link: https://github.com/ClangBuiltLinux/linux/issues/415
Link: https://github.com/ClangBuiltLinux/linux/issues/499
Link: https://github.com/llvm/llvm-project/commit/2e040398f8d691cc378c1abb098824ff49f3f28f
Link: https://github.com/llvm/llvm-project/commit/c667cdc850c2aa821ffeedbc08c24bc985c59edd
Fixes: 7ad6b09f2247 ("drm/i915: Disable -Wuninitialized")
References: ea0aba3873e3 ("drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show")
References: f93426bd9099 ("drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state")
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20210216212953.24458-1-nathan@kernel.org
drivers/gpu/drm/i915/Makefile