]> git.baikalelectronics.ru Git - kernel.git/commit
PM: Print a warning if firmware is requested when tasks are frozen
authorRafael J. Wysocki <rjw@sisk.pl>
Fri, 6 May 2011 18:09:42 +0000 (20:09 +0200)
committerRafael J. Wysocki <rjw@sisk.pl>
Tue, 17 May 2011 21:19:17 +0000 (23:19 +0200)
commitb6d979b931d7f0e510cc6e99a6671e781f1d8b85
tree10cab9080a722a191086f58b9f304329e8a8b942
parent508574fffac66d640df9854f93702317e1e30314
PM: Print a warning if firmware is requested when tasks are frozen

Some drivers erroneously use request_firmware() from their ->resume()
(or ->thaw(), or ->restore()) callbacks, which is not going to work
unless the firmware has been built in.  This causes system resume to
stall until the firmware-loading timeout expires, which makes users
think that the resume has failed and reboot their machines
unnecessarily.  For this reason, make _request_firmware() print a
warning and return immediately with error code if it has been called
when tasks are frozen and it's impossible to start any new usermode
helpers.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Reviewed-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
drivers/base/firmware_class.c
include/linux/kmod.h
kernel/kmod.c