]> git.baikalelectronics.ru Git - kernel.git/commit
spi: spidev: Fix CS polarity if GPIO descriptors are used
authorLukas Wunner <lukas@wunner.de>
Tue, 18 Feb 2020 12:08:00 +0000 (13:08 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 21 Feb 2020 13:50:36 +0000 (13:50 +0000)
commitae4abee1686dd0266ca55c3132ae9d5d986e18ed
tree18d9d16b9fa2b80237666a4b6c67d906f2017ba0
parent96605312d8bf54b4b321242a4a6701d3f25a63cb
spi: spidev: Fix CS polarity if GPIO descriptors are used

Commit 9bc982f86df7 ("spi: Optionally use GPIO descriptors for CS GPIOs")
amended of_spi_parse_dt() to always set SPI_CS_HIGH for SPI slaves whose
Chip Select is defined by a "cs-gpios" devicetree property.

This change broke userspace applications which issue an SPI_IOC_WR_MODE
ioctl() to an spidev:  Chip Select polarity will be incorrect unless the
application is changed to set SPI_CS_HIGH.  And once changed, it will be
incompatible with kernels not containing the commit.

Fix by setting SPI_CS_HIGH in spidev_ioctl() (under the same conditions
as in of_spi_parse_dt()).

Fixes: 9bc982f86df7 ("spi: Optionally use GPIO descriptors for CS GPIOs")
Reported-by: Simon Han <z.han@kunbus.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/fca3ba7cdc930cd36854666ceac4fbcf01b89028.1582027457.git.lukas@wunner.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org # v5.1+
drivers/spi/spidev.c