]> git.baikalelectronics.ru Git - kernel.git/commit
ipv4: Don't do expensive useless work during inetdev destroy.
authorDavid S. Miller <davem@davemloft.net>
Mon, 14 Mar 2016 03:28:00 +0000 (23:28 -0400)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Mar 2016 03:28:35 +0000 (23:28 -0400)
commita7453721fdbbfce168f3cfd05994034195aa414c
treef6a14f38046fe2dfa10e3295d1e6a059010097a1
parent407d3ef864091f0ea95ead6454c2af4b1661944f
ipv4: Don't do expensive useless work during inetdev destroy.

When an inetdev is destroyed, every address assigned to the interface
is removed.  And in this scenerio we do two pointless things which can
be very expensive if the number of assigned interfaces is large:

1) Address promotion.  We are deleting all addresses, so there is no
   point in doing this.

2) A full nf conntrack table purge for every address.  We only need to
   do this once, as is already caught by the existing
   masq_dev_notifier so masq_inet_event() can skip this.

Reported-by: Solar Designer <solar@openwall.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Tested-by: Cyrill Gorcunov <gorcunov@openvz.org>
net/ipv4/devinet.c
net/ipv4/fib_frontend.c
net/ipv4/netfilter/nf_nat_masquerade_ipv4.c