pwm: Set enable state properly on failed call to enable
authorJonathan Richardson <jonathar@broadcom.com>
Sat, 17 Oct 2015 00:40:58 +0000 (17:40 -0700)
committerThierry Reding <thierry.reding@gmail.com>
Tue, 10 Nov 2015 12:06:16 +0000 (13:06 +0100)
commit90c8d3bb032c6606c95c47190b5765a30db00ccb
tree429e8844a75def440f47479f751e60f9ff685f0c
parent729ae0f35b6486488a36a20eeebfac8d8d1eb6ef
pwm: Set enable state properly on failed call to enable

The pwm_enable() function didn't clear the enabled bit if a call to the
driver's ->enable() callback returned an error. The result was that the
state of the PWM core was wrong. Clearing the bit when enable returns
an error ensures the state is properly set.

Tested-by: Jonathan Richardson <jonathar@broadcom.com>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Jonathan Richardson <jonathar@broadcom.com>
[thierry.reding@gmail.com: add missing kerneldoc for the lock]
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/core.c
include/linux/pwm.h