]> git.baikalelectronics.ru Git - kernel.git/commit
net: stmmac: initialize the reset delay array
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Tue, 18 Jun 2019 20:39:27 +0000 (22:39 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 19 Jun 2019 21:40:49 +0000 (17:40 -0400)
commit8f0bc84732c3db3cf22d9d7fa6e6a56c82224ca2
tree799526c7d6ed8338c67c2fa2b4cb5c58c3f785c8
parentc9c71a1cbf004776175acaa2ff18726d9027a581
net: stmmac: initialize the reset delay array

Commit 5d8e1863802404 ("net: stmmac: drop the reset delays from struct
stmmac_mdio_bus_data") moved the reset delay array from struct
stmmac_mdio_bus_data to a stack variable.
The values from the array inside struct stmmac_mdio_bus_data were
previously initialized to 0 because the struct was allocated using
devm_kzalloc(). The array on the stack has to be initialized
explicitly, else we might be reading garbage values.

Initialize all reset delays to 0 to ensure that the values are 0 if the
"snps,reset-delays-us" property is not defined.
This fixes booting at least two boards (MIPS pistachio marduk and ARM
sun8i H2+ Orange Pi Zero). These are hanging during boot when
initializing the stmmac Ethernet controller (as found by Kernel CI).
Both have in common that they don't define the "snps,reset-delays-us"
property.

Fixes: 5d8e1863802404 ("net: stmmac: drop the reset delays from struct stmmac_mdio_bus_data")
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reported-by: "kernelci.org bot" <bot@kernelci.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c