]> git.baikalelectronics.ru Git - kernel.git/commit
x86/apic: Include the LDR when clearing out APIC registers
authorBandan Das <bsd@redhat.com>
Mon, 26 Aug 2019 10:15:13 +0000 (06:15 -0400)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 26 Aug 2019 18:00:57 +0000 (20:00 +0200)
commit8c2f22ed6c725f68bb158f0a436be4016c688c28
tree93a1b446bc79e1da48a9097acca77f0167426687
parent3ca4667d1464e8a7786a2d82b65d733509d6a356
x86/apic: Include the LDR when clearing out APIC registers

Although APIC initialization will typically clear out the LDR before
setting it, the APIC cleanup code should reset the LDR.

This was discovered with a 32-bit KVM guest jumping into a kdump
kernel. The stale bits in the LDR triggered a bug in the KVM APIC
implementation which caused the destination mapping for VCPUs to be
corrupted.

Note that this isn't intended to paper over the KVM APIC bug. The kernel
has to clear the LDR when resetting the APIC registers except when X2APIC
is enabled.

This lacks a Fixes tag because missing to clear LDR goes way back into pre
git history.

[ tglx: Made x2apic_enabled a function call as required ]

Signed-off-by: Bandan Das <bsd@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20190826101513.5080-3-bsd@redhat.com
arch/x86/kernel/apic/apic.c