]> git.baikalelectronics.ru Git - kernel.git/commit
selftests: Fix selftests build to just build, not run tests
authorMichael Ellerman <mpe@ellerman.id.au>
Thu, 9 Feb 2017 08:56:26 +0000 (19:56 +1100)
committerShuah Khan <shuahkh@osg.samsung.com>
Tue, 14 Feb 2017 15:01:44 +0000 (08:01 -0700)
commit8b7eb2fcdfd0edcc363dc078c39f18fc8f048649
tree3b41b7115f3dfaf83ea9b119cb9ae1a5f90c50fe
parentc426635c93c8ff633ae7faad1d24a2b74b3c2206
selftests: Fix selftests build to just build, not run tests

In commit c239efb0ac3b ("selftests: remove duplicated all and clean
target"), the "all" target was removed from individual Makefiles and
added to lib.mk.

However the "all" target was added to lib.mk *after* the existing
"runtests" target. This means "runtests" becomes the first (default)
target for most of our Makefiles.

This has the effect of causing a plain "make" to build *and run* the
tests. Which is at best rude, but depending on which tests are run could
oops someone's build machine.

  $ make -C tools/testing/selftests/
  ...
  make[1]: Entering directory 'tools/testing/selftests/bpf'
  gcc -Wall -O2 -I../../../../usr/include   test_verifier.c -o tools/testing/selftests/bpf/test_verifier
  gcc -Wall -O2 -I../../../../usr/include   test_maps.c -o tools/testing/selftests/bpf/test_maps
  gcc -Wall -O2 -I../../../../usr/include   test_lru_map.c -o tools/testing/selftests/bpf/test_lru_map
  #0 add+sub+mul FAIL
  Failed to load prog 'Function not implemented'!
  #1 unreachable FAIL
  Unexpected error message!
  #2 unreachable2 FAIL
  ...

Fix it by moving the "all" target to the start of lib.mk, making it the
default target.

Fixes: c239efb0ac3b ("selftests: remove duplicated all and clean target")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Tested by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
tools/testing/selftests/lib.mk