]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: b53: Keep CPU port as tagged in all VLANs
authorFlorian Fainelli <f.fainelli@gmail.com>
Fri, 5 Oct 2018 03:24:13 +0000 (20:24 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 5 Oct 2018 04:52:49 +0000 (21:52 -0700)
commit846cdda028bb115df39104ba55397a18471c7f2e
treec24ede5ccead8729da4400bc81a6147fefcfcc77
parentc43831a400fa55076fe49bc8466c4a5d846a8246
net: dsa: b53: Keep CPU port as tagged in all VLANs

Commit 35a17f8173f1 ("net: dsa: b53: Stop using dev->cpu_port
incorrectly") was a bit too trigger happy in removing the CPU port from
the VLAN membership because we rely on DSA to program the CPU port VLAN,
which it does, except it does not bother itself with tagged/untagged and
just usese untagged.

Having the CPU port "follow" the user ports tagged/untagged is not great
and does not allow for properly differentiating, so keep the CPU port
tagged in all VLANs.

Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
Fixes: 35a17f8173f1 ("net: dsa: b53: Stop using dev->cpu_port incorrectly")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/b53/b53_common.c