]> git.baikalelectronics.ru Git - kernel.git/commit
net: clear heap allocations for privileged ethtool actions
authorKees Cook <kees.cook@canonical.com>
Mon, 11 Oct 2010 19:23:25 +0000 (12:23 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 11 Oct 2010 19:23:25 +0000 (12:23 -0700)
commit844be28b2070829429de4cf0b2c72ba047c406df
treecc5c416e5bc6ba69534ce880cc135364dcb91baa
parent8a47d750b567721381f327b83658e3de0daaafef
net: clear heap allocations for privileged ethtool actions

Several other ethtool functions leave heap uncleared (potentially) by
drivers. Some interfaces appear safe (eeprom, etc), in that the sizes
are well controlled. In some situations (e.g. unchecked error conditions),
the heap will remain unchanged in areas before copying back to userspace.
Note that these are less of an issue since these all require CAP_NET_ADMIN.

Cc: stable@kernel.org
Signed-off-by: Kees Cook <kees.cook@canonical.com>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/ethtool.c