]> git.baikalelectronics.ru Git - kernel.git/commit
[NET]: Clean up sk_buff walkers.
authorJean Delvare <jdelvare@suse.de>
Thu, 26 Apr 2007 07:44:22 +0000 (00:44 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 26 Apr 2007 07:44:22 +0000 (00:44 -0700)
commit7bd1629d2d0527cd2addcf337ee7128b6fb16a14
treea4e1f3b8dca04b8dff3cd99dc43f771f798558fb
parent1bdd7594dbbc6469aa400425410db8a4c6702e12
[NET]: Clean up sk_buff walkers.

I noticed recently that, in skb_checksum(), "offset" and "start" are
essentially the same thing and have the same value throughout the
function, despite being computed differently. Using a single variable
allows some cleanups and makes the skb_checksum() function smaller,
more readable, and presumably marginally faster.

We appear to have many other "sk_buff walker" functions built on the
exact same model, so the cleanup applies to them, too. Here is a list
of the functions I found to be affected:

net/appletalk/ddp.c:atalk_sum_skb()
net/core/datagram.c:skb_copy_datagram_iovec()
net/core/datagram.c:skb_copy_and_csum_datagram()
net/core/skbuff.c:skb_copy_bits()
net/core/skbuff.c:skb_store_bits()
net/core/skbuff.c:skb_checksum()
net/core/skbuff.c:skb_copy_and_csum_bit()
net/core/user_dma.c:dma_skb_copy_datagram_iovec()
net/xfrm/xfrm_algo.c:skb_icv_walk()
net/xfrm/xfrm_algo.c:skb_to_sgvec()

OTOH, I admit I'm a bit surprised, the cleanup is rather obvious so I'm
really wondering if I am missing something. Can anyone please comment
on this?

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/appletalk/ddp.c
net/core/datagram.c
net/core/skbuff.c
net/core/user_dma.c
net/xfrm/xfrm_algo.c