]> git.baikalelectronics.ru Git - kernel.git/commit
kfifo: fix kfifo_to_user() return type
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 24 Jun 2022 05:30:04 +0000 (08:30 +0300)
committerakpm <akpm@linux-foundation.org>
Mon, 18 Jul 2022 00:31:38 +0000 (17:31 -0700)
commit773ac7caabcbbae504658d302e2d268817b2147d
tree436603b559b6b2721087f258da522aa523efce68
parentdd5b728a53054d921531d5003bb39c2c912ed03f
kfifo: fix kfifo_to_user() return type

The kfifo_to_user() macro is supposed to return zero for success or
negative error codes.  Unfortunately, there is a signedness bug so it
returns unsigned int.  This only affects callers which try to save the
result in ssize_t and as far as I can see the only place which does that
is line6_hwdep_read().

TL;DR: s/_uint/_int/.

Link: https://lkml.kernel.org/r/YrVL3OJVLlNhIMFs@kili
Fixes: 77b8f66938e3 ("kfifo: fix kfifo_alloc() to return a signed int value")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Stefani Seibold <stefani@seibold.net>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/kfifo.h