]> git.baikalelectronics.ru Git - kernel.git/commit
dax: fix detection of dax support for non-persistent memory block devices
authorColy Li <colyli@suse.de>
Thu, 3 Sep 2020 16:16:25 +0000 (00:16 +0800)
committerVishal Verma <vishal.l.verma@intel.com>
Thu, 3 Sep 2020 18:28:03 +0000 (12:28 -0600)
commit5f5682aadd25b2871a87e42ef66de185932c7a7c
tree0d0f5e84fccdb4aa4296285c21dc1400d729d330
parent210c80925a650b1f81c916dddb122f3dca2c90f5
dax: fix detection of dax support for non-persistent memory block devices

When calling __generic_fsdax_supported(), a dax-unsupported device may
not have dax_dev as NULL, e.g. the dax related code block is not enabled
by Kconfig.

Therefore in __generic_fsdax_supported(), to check whether a device
supports DAX or not, the following order of operations should be
performed:
- If dax_dev pointer is NULL, it means the device driver explicitly
  announce it doesn't support DAX. Then it is OK to directly return
  false from __generic_fsdax_supported().
- If dax_dev pointer is NOT NULL, it might be because the driver doesn't
  support DAX and not explicitly initialize related data structure. Then
  bdev_dax_supported() should be called for further check.

If device driver desn't explicitly set its dax_dev pointer to NULL,
this is not a bug. Calling bdev_dax_supported() makes sure they can be
recognized as dax-unsupported eventually.

Fixes: 210c80925a65 ("dax: do not print error message for non-persistent memory block device")
Cc: Jan Kara <jack@suse.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>
Reviewed-and-tested-by: Adrian Huang <ahuang12@lenovo.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
Link: https://lore.kernel.org/r/20200903161625.19524-1-colyli@suse.de
drivers/dax/super.c