]> git.baikalelectronics.ru Git - kernel.git/commit
mtd: rawnand: meson: Fix a potential double free issue
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 20 May 2022 16:41:40 +0000 (18:41 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Mon, 6 Jun 2022 12:58:26 +0000 (14:58 +0200)
commit5e53443dc70aef3086f90a8223f04f1e6080bddb
treebf0c9cced4911007cc45d5bd050e67cc3d9a52e3
parent2f7c4618e2c9c25f6f88c803d4492c351d6162fb
mtd: rawnand: meson: Fix a potential double free issue

When meson_nfc_nand_chip_cleanup() is called, it will call:
meson_nfc_free_buffer(&meson_chip->nand);
nand_cleanup(&meson_chip->nand);

nand_cleanup() in turn will call nand_detach() which calls the
.detach_chip() which is here meson_nand_detach_chip().

meson_nand_detach_chip() already calls meson_nfc_free_buffer(), so we
could double free some memory.

Fix it by removing the unneeded explicit call to meson_nfc_free_buffer().

Fixes: a8b6ef1f6111 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Liang Yang <liang.yang@amlogic.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/ec15c358b8063f7c50ff4cd628cf0d2e14e43f49.1653064877.git.christophe.jaillet@wanadoo.fr
drivers/mtd/nand/raw/meson_nand.c