]> git.baikalelectronics.ru Git - kernel.git/commit
iwlagn: enable only rfkill interrupt when device is down
authorStanislaw Gruszka <sgruszka@redhat.com>
Thu, 23 Dec 2010 11:38:21 +0000 (12:38 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 4 Jan 2011 19:15:08 +0000 (14:15 -0500)
commit5befa754be0dea9302e56d45d76ed018f0598ed5
tree5f8439d45b8ed972201dfcbdc8dd88533e88cd97
parent980057befd120433ad4e929e70320aaa2bf37ecb
iwlagn: enable only rfkill interrupt when device is down

Since commit 4d4d378ad54e418eb3b48164c862769ae562d7b3 "iwlagn: fix
hw-rfkill while the interface is down", we enable interrupts when
device is not ready to receive them. However hardware, when it is in
some inconsistent state, can generate other than rfkill interrupts
and crash the system. I can reproduce crash with "kernel BUG at
drivers/net/wireless/iwlwifi/iwl-agn.c:1010!" message, when forcing
firmware restarts.

To fix only enable rfkill interrupt when down device and after probe.
I checked patch on laptop with 5100 device, rfkill change is still
passed to user space when device is down.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: stable@kernel.org
Acked-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/iwlwifi/iwl-agn.c
drivers/net/wireless/iwlwifi/iwl-helpers.h