]> git.baikalelectronics.ru Git - kernel.git/commit
drm/vc4: hdmi: Rework power up
authorMaxime Ripard <maxime@cerno.tech>
Wed, 29 Jun 2022 12:34:37 +0000 (14:34 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Fri, 8 Jul 2022 08:45:41 +0000 (10:45 +0200)
commit53565c28e6af2cef6bbf438c34250135e3564459
tree4bf571e53904246d772d1630dea84a4d9553eef1
parentf1bc386b319e93e56453ae27e9e83817bb1f6f95
drm/vc4: hdmi: Rework power up

The current code tries to handle the case where CONFIG_PM isn't selected
by first calling our runtime_resume implementation and then properly
report the power state to the runtime_pm core.

This allows to have a functionning device even if pm_runtime_get_*
functions are nops.

However, the device power state if CONFIG_PM is enabled is
RPM_SUSPENDED, and thus our vc4_hdmi_write() and vc4_hdmi_read() calls
in the runtime_pm hooks will now report a warning since the device might
not be properly powered.

Even more so, we need CONFIG_PM enabled since the previous RaspberryPi
have a power domain that needs to be powered up for the HDMI controller
to be usable.

The previous patch has created a dependency on CONFIG_PM, now we can
just assume it's there and only call pm_runtime_resume_and_get() to make
sure our device is powered in bind.

Link: https://lore.kernel.org/r/20220629123510.1915022-39-maxime@cerno.tech
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
drivers/gpu/drm/vc4/vc4_hdmi.c