]> git.baikalelectronics.ru Git - kernel.git/commit
ovl: fix BUG_ON() in may_delete() when called from ovl_cleanup()
authorchenying <chenying.kernel@bytedance.com>
Mon, 16 Aug 2021 10:02:56 +0000 (18:02 +0800)
committerMiklos Szeredi <mszeredi@redhat.com>
Tue, 17 Aug 2021 15:37:53 +0000 (17:37 +0200)
commit52d5a0c6bd8a89f460243ed937856354f8f253a3
tree3768f7f260041199ccabbab03f0fc6a37dfbadd2
parentf945ca1963c8bd29471020d7c58c594ee7007006
ovl: fix BUG_ON() in may_delete() when called from ovl_cleanup()

If function ovl_instantiate() returns an error, ovl_cleanup will be called
and try to remove newdentry from wdir, but the newdentry has been moved to
udir at this time.  This will causes BUG_ON(victim->d_parent->d_inode !=
dir) in fs/namei.c:may_delete.

Signed-off-by: chenying <chenying.kernel@bytedance.com>
Fixes: 01b39dcc9568 ("ovl: use inode_insert5() to hash a newly created inode")
Link: https://lore.kernel.org/linux-unionfs/e6496a94-a161-dc04-c38a-d2544633acb4@bytedance.com/
Cc: <stable@vger.kernel.org> # v4.18
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/overlayfs/dir.c