]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: core: Fix shost->cmd_per_lun calculation in scsi_add_host_with_dma()
authorDexuan Cui <decui@microsoft.com>
Fri, 8 Oct 2021 04:35:46 +0000 (21:35 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 12 Oct 2021 16:37:15 +0000 (12:37 -0400)
commit50b6cb3516365cb69753b006be2b61c966b70588
tree52166e9ebb497f953138b8af2906da363ad7b98a
parent258aad75c62146453d03028a44f2f1590d58e1f6
scsi: core: Fix shost->cmd_per_lun calculation in scsi_add_host_with_dma()

After commit ea2f0f77538c ("scsi: core: Cap scsi_host cmd_per_lun at
can_queue"), a 416-CPU VM running on Hyper-V hangs during boot because the
hv_storvsc driver sets scsi_driver.can_queue to an integer value that
exceeds SHRT_MAX, and hence scsi_add_host_with_dma() sets
shost->cmd_per_lun to a negative "short" value.

Use min_t(int, ...) to work around the issue.

Link: https://lore.kernel.org/r/20211008043546.6006-1-decui@microsoft.com
Fixes: ea2f0f77538c ("scsi: core: Cap scsi_host cmd_per_lun at can_queue")
Cc: stable@vger.kernel.org
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: John Garry <john.garry@huawei.com>
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hosts.c