]> git.baikalelectronics.ru Git - kernel.git/commit
netlink: do not enter direct reclaim from netlink_dump()
authorEric Dumazet <edumazet@google.com>
Wed, 5 Oct 2016 19:13:18 +0000 (04:13 +0900)
committerDavid S. Miller <davem@davemloft.net>
Fri, 7 Oct 2016 00:53:13 +0000 (20:53 -0400)
commit4fcaec44cd92c353725b61d4beadcad40825a641
tree35c9a4b47ffd67aa85672dca5bd84d6c83e7a8df
parentc8051ea796de8a1939b0e7a38e96fa75f803b61f
netlink: do not enter direct reclaim from netlink_dump()

Since linux-3.15, netlink_dump() can use up to 16384 bytes skb
allocations.

Due to struct skb_shared_info ~320 bytes overhead, we end up using
order-3 (on x86) page allocations, that might trigger direct reclaim and
add stress.

The intent was really to attempt a large allocation but immediately
fallback to a smaller one (order-1 on x86) in case of memory stress.

On recent kernels (linux-4.4), we can remove __GFP_DIRECT_RECLAIM to
meet the goal. Old kernels would need to remove __GFP_WAIT

While we are at it, since we do an order-3 allocation, allow to use
all the allocated bytes instead of 16384 to reduce syscalls during
large dumps.

iproute2 already uses 32KB recvmsg() buffer sizes.

Alexei provided an initial patch downsizing to SKB_WITH_OVERHEAD(16384)

Fixes: 5be28810e202 ("netlink: autosize skb lengthes")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Alexei Starovoitov <ast@kernel.org>
Cc: Greg Thelen <gthelen@google.com>
Reviewed-by: Greg Rose <grose@lightfleet.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netlink/af_netlink.c