]> git.baikalelectronics.ru Git - kernel.git/commit
gpio: amd8111: Fix PCI device reference count leak
authorXiongfeng Wang <wangxiongfeng2@huawei.com>
Tue, 22 Nov 2022 12:35:08 +0000 (20:35 +0800)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 30 Nov 2022 16:18:35 +0000 (17:18 +0100)
commit45fecdb9f658d9c82960c98240bc0770ade19aca
treeae4376397c6223c70b1174d272bdd1a3b9b0d866
parentec851b23084b3a0af8bf0f5e51d33a8d678bdc49
gpio: amd8111: Fix PCI device reference count leak

for_each_pci_dev() is implemented by pci_get_device(). The comment of
pci_get_device() says that it will increase the reference count for the
returned pci_dev and also decrease the reference count for the input
pci_dev @from if it is not NULL.

If we break for_each_pci_dev() loop with pdev not NULL, we need to call
pci_dev_put() to decrease the reference count. Add the missing
pci_dev_put() after the 'out' label. Since pci_dev_put() can handle NULL
input parameter, there is no problem for the 'Device not found' branch.
For the normal path, add pci_dev_put() in amd_gpio_exit().

Fixes: f942a7de047d ("gpio: add a driver for GPIO pins found on AMD-8111 south bridge chips")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-amd8111.c