]> git.baikalelectronics.ru Git - kernel.git/commit
rcu: Abstract out rcu_irq_enter_check_tick() from rcu_nmi_enter()
authorPaul E. McKenney <paulmck@kernel.org>
Thu, 21 May 2020 20:05:15 +0000 (22:05 +0200)
committerIngo Molnar <mingo@kernel.org>
Tue, 26 May 2020 17:04:18 +0000 (19:04 +0200)
commit43000005a9175acf32d1192720ab2952014bc4d4
treef692b24126d8121a4a311e708a04110102b7f84d
parentf935f02a5c354083f6708b450edef131417b389e
rcu: Abstract out rcu_irq_enter_check_tick() from rcu_nmi_enter()

There will likely be exception handlers that can sleep, which rules
out the usual approach of invoking rcu_nmi_enter() on entry and also
rcu_nmi_exit() on all exit paths.  However, the alternative approach of
just not calling anything can prevent RCU from coaxing quiescent states
from nohz_full CPUs that are looping in the kernel:  RCU must instead
IPI them explicitly.  It would be better to enable the scheduler tick
on such CPUs to interact with RCU in a lighter-weight manner, and this
enabling is one of the things that rcu_nmi_enter() currently does.

What is needed is something that helps RCU coax quiescent states while
not preventing subsequent sleeps.  This commit therefore splits out the
nohz_full scheduler-tick enabling from the rest of the rcu_nmi_enter()
logic into a new function named rcu_irq_enter_check_tick().

[ tglx: Renamed the function and made it a nop when context tracking is off ]
[ mingo: Fixed a CONFIG_NO_HZ_FULL assumption, harmonized and fixed all the
         comment blocks and cleaned up rcu_nmi_enter()/exit() definitions. ]

Suggested-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20200521202116.996113173@linutronix.de
include/linux/hardirq.h
kernel/rcu/tree.c