]> git.baikalelectronics.ru Git - kernel.git/commit
regmap: Fix possible shift overflow in regmap_field_init()
authorMaxime Coquelin <maxime.coquelin@st.com>
Tue, 16 Jun 2015 11:53:19 +0000 (13:53 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 16 Jun 2015 11:58:22 +0000 (12:58 +0100)
commit3eaab4d4cee9d201ddaa095bbe7a224ead646f3b
treeb5d577496add5052fa5facd1c969d9df93251236
parentce88222e1fb53c38d3b94c3b5ceebe1d2ab4956d
regmap: Fix possible shift overflow in regmap_field_init()

The way the mask is generated in regmap_field_init() is wrong.
Indeed, a field initialized with msb = 31 and lsb = 0 provokes a shift
overflow while calculating the mask field.

On some 32 bits architectures, such as x86, the generated mask is 0,
instead of the expected 0xffffffff.

This patch uses GENMASK() to fix the problem, as this macro is already safe
regarding shift overflow.

Signed-off-by: Maxime Coquelin <maxime.coquelin@st.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
drivers/base/regmap/regmap.c