]> git.baikalelectronics.ru Git - kernel.git/commit
net: encx24j600: Fix invalid logic in reading of MISTAT register
authorValentina Goncharenko <goncharenko.vp@ispras.ru>
Thu, 1 Dec 2022 17:34:08 +0000 (20:34 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Dec 2022 09:46:31 +0000 (09:46 +0000)
commit25f427ac7b8d89b0259f86c0c6407b329df742b2
treee37a5034ab0348d50cfdae9fc5dd8872c03ce7a6
parent167b3f2dcc62c271f3555b33df17e361bb1fa0ee
net: encx24j600: Fix invalid logic in reading of MISTAT register

A loop for reading MISTAT register continues while regmap_read() fails
and (mistat & BUSY), but if regmap_read() fails a value of mistat is
undefined.

The patch proposes to check for BUSY flag only when regmap_read()
succeed. Compile test only.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: d70e53262f5c ("net: Microchip encx24j600 driver")
Signed-off-by: Valentina Goncharenko <goncharenko.vp@ispras.ru>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/microchip/encx24j600-regmap.c