]> git.baikalelectronics.ru Git - kernel.git/commit
staging: tidspbridge: use safer test on the result of find_first_zero_bit
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 4 Jun 2014 09:07:54 +0000 (11:07 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Jun 2014 22:23:05 +0000 (15:23 -0700)
commit1b8ad3cb4381d33a145eada8a08a1b9ba0aab78f
treea7db573768301109dc3f49123f34416c21b432ea
parent3eae4fcd7aec22fd32d0f03caa310de8ac64b296
staging: tidspbridge: use safer test on the result of find_first_zero_bit

Find_first_zero_bit considers BITS_PER_LONG bits at a time, and thus may
return a larger number than the maximum position argument if that position
is not a multiple of BITS_PER_LONG.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2,e3;
statement S1,S2;
@@

e1 = find_first_zero_bit(e2,e3)
...
if (e1
- ==
+ >=
  e3)
S1 else S2
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/tidspbridge/rmgr/node.c