]> git.baikalelectronics.ru Git - kernel.git/commit
random: check for signal_pending() outside of need_resched() check
authorJann Horn <jannh@google.com>
Tue, 5 Apr 2022 16:39:31 +0000 (18:39 +0200)
committerJason A. Donenfeld <Jason@zx2c4.com>
Wed, 6 Apr 2022 13:09:33 +0000 (15:09 +0200)
commit1448769c9cdb69ad65287f4f7ab58bc5f2f5d7ba
tree457e2d91ba4a10facd9e511015c6808e6bc64709
parentaba120cc101788544aa3e2c30c8da88513892350
random: check for signal_pending() outside of need_resched() check

signal_pending() checks TIF_NOTIFY_SIGNAL and TIF_SIGPENDING, which
signal that the task should bail out of the syscall when possible. This
is a separate concept from need_resched(), which checks
TIF_NEED_RESCHED, signaling that the task should preempt.

In particular, with the current code, the signal_pending() bailout
probably won't work reliably.

Change this to look like other functions that read lots of data, such as
read_zero().

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
drivers/char/random.c