]> git.baikalelectronics.ru Git - kernel.git/commit
HID: i2c-hid: Remove runtime power management
authorKai-Heng Feng <kai.heng.feng@canonical.com>
Wed, 16 Oct 2019 15:12:24 +0000 (23:12 +0800)
committerBenjamin Tissoires <benjamin.tissoires@redhat.com>
Fri, 18 Oct 2019 13:29:56 +0000 (15:29 +0200)
commit0fa4bc4318c55b556c37456729888defa1675452
tree7d850dccdc2d0074bc61654d6c822dce0b2feaac
parentccbc6fa1b5687c1a845f61292bfe55bf7bce7595
HID: i2c-hid: Remove runtime power management

Runtime power management in i2c-hid brings lots of issues, such as:
- When transitioning from display manager to desktop session, i2c-hid
was closed and opened, so the device was set to SLEEP and ON in a short
period. Vendors confirmed that their devices can't handle fast ON/SLEEP
command because Windows doesn't have this behavior.

- When rebooting, i2c-hid was closed, and the driver core put the device
back to full power before shutdown. This behavior also triggers a quick
SLEEP and ON commands that some devices can't handle, renders an
unusable touchpad after reboot.

- Most importantly, my power meter reports little to none energy saving
when i2c-hid is runtime suspended.

So let's remove runtime power management since there is no actual
benefit.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
drivers/hid/i2c-hid/i2c-hid-core.c