]>
git.baikalelectronics.ru Git - kernel.git/log
Masahiro Yamada [Tue, 5 May 2020 10:03:19 +0000 (19:03 +0900)]
scripts/dtc: use pkg-config to include <yaml.h> in non-standard path
Commit
09f68c6e793f ("dtc: Use pkg-config to locate libyaml") added
'pkg-config --libs' to link libyaml installed in a non-standard
location.
yamltree.c includes <yaml.h>, but that commit did not add the search
path for <yaml.h>. If /usr/include/yaml.h does not exist, it fails to
build. A user can explicitly pass HOSTCFLAGS to work around it, but
the policy is not consistent.
There are two ways to deal with libraries in a non-default location.
[1] Use HOSTCFLAGS and HOSTLDFLAGS for additional search paths for
headers and libraries.
They are documented in Documentation/kbuild/kbuild.rst
$ make HOSTCFLAGS='-I <prefix>/include' HOSTLDFLAGS='-L <prefix>/lib'
[2] Use pkg-config
'pkg-config --cflags' for querying the header search path
'pkg-config --libs' for querying the lib and its path
If we go with pkg-config, use [2] consistently. Do not mix up
[1] and [2].
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
周琰杰 (Zhou Yanjie) [Thu, 28 May 2020 03:15:45 +0000 (11:15 +0800)]
dt-bindings: clock: Add documentation for X1830 bindings.
Add documentation for the clock bindings of the X1830 Soc from Ingenic.
Reviewed-by: Rob Herring <robh@kernel.org>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Mon, 1 Jun 2020 10:37:44 +0000 (18:37 +0800)]
dt-bindings: mailbox: Convert imx mu to json-schema
Convert the i.MX MU binding to DT schema format using json-schema
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Mon, 1 Jun 2020 08:06:43 +0000 (16:06 +0800)]
dt-bindings: power: Convert imx gpcv2 to json-schema
Convert the i.MX GPCv2 binding to DT schema format using json-schema
Example is updated based on latest DT file and consumer's example is
removed since it is NOT that useful.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Mon, 1 Jun 2020 08:06:42 +0000 (16:06 +0800)]
dt-bindings: power: Convert imx gpc to json-schema
Convert the i.MX GPC binding to DT schema format using json-schema
>From latest reference manual, there is actually ONLY 1 interrupt for
GPC, so the additional GPC interrupt is removed.
Consumer's example is also removed since it is NOT that useful.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Thierry Reding [Fri, 29 May 2020 18:06:31 +0000 (20:06 +0200)]
dt-bindings: Merge gpio-usb-b-connector with usb-connector
The binding for usb-connector is a superset of gpio-usb-b-connector. One
major difference is that gpio-usb-b-connector requires at least one of
the vbus-gpios and id-gpios properties to be specified. Merge the two
bindings by adding the compatible string combination for the GPIO USB-B
variant and an extra conditional for the required properties list to the
usb-connector.yaml file.
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Geert Uytterhoeven [Tue, 5 May 2020 15:51:27 +0000 (17:51 +0200)]
dt-bindings: timer: renesas: cmt: Convert to json-schema
Convert the Renesas Compare Match Timer (CMT) Device Tree binding
documentation to json-schema.
Document missing properties.
Update the example to match reality.
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Fri, 29 May 2020 06:21:39 +0000 (14:21 +0800)]
dt-bindings: clock: Convert i.MX8QXP LPCG to json-schema
Convert the i.MX8QXP LPCG binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
[robh: add additionalProperties]
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Fri, 29 May 2020 02:04:42 +0000 (10:04 +0800)]
dt-bindings: timer: Convert i.MX GPT to json-schema
Convert the i.MX GPT binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Lad Prabhakar [Wed, 27 May 2020 21:18:37 +0000 (22:18 +0100)]
dt-bindings: thermal: rcar-thermal: Add device tree support for r8a7742
Add thermal sensor support for r8a7742 SoC. The Renesas RZ/G1H
(r8a7742) thermal sensor module is identical to the R-Car Gen2 family.
No driver change is needed due to the fallback compatible value
"renesas,rcar-gen2-thermal".
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Akash Asthana [Wed, 27 May 2020 06:27:44 +0000 (11:57 +0530)]
dt-bindings: serial: Add binding for UART pin swap
Add documentation to support RX-TX & CTS-RTS GPIO pin swap in HW.
Signed-off-by: Akash Asthana <akashast@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Akash Asthana [Wed, 27 May 2020 06:27:43 +0000 (11:57 +0530)]
dt-bindings: geni-se: Add interconnect binding for GENI QUP
Add documentation for the interconnect and interconnect-names properties
for the GENI QUP.
Signed-off-by: Akash Asthana <akashast@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Akash Asthana [Wed, 27 May 2020 06:27:42 +0000 (11:57 +0530)]
dt-bindings: geni-se: Convert QUP geni-se bindings to YAML
Convert QUP geni-se bindings to DT schema format using json-schema.
Signed-off-by: Akash Asthana <akashast@codeaurora.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
[robh: Fix up example warnings]
Signed-off-by: Rob Herring <robh@kernel.org>
Olivier Sobrie [Mon, 25 May 2020 19:56:04 +0000 (21:56 +0200)]
dt-bindings: vendor-prefixes: Add Silex Insight vendor prefix
Silex Insight is a microelectronic company whose headquarter is located
in Belgium.
Web site of the company: https://www.silexinsight.com/
Signed-off-by: Olivier Sobrie <olivier.sobrie@silexinsight.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Johan Jonker [Wed, 20 May 2020 07:33:27 +0000 (09:33 +0200)]
dt-bindings: input: touchscreen: edt-ft5x06: change reg property
A test with the command below gives this error:
arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml:
touchscreen@3e: reg:0:0: 56 was expected
The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models
was shipped with different addresses then the binding currently allows.
Change the reg property that any address will pass.
make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/
edt-ft5x06.yaml
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Rob Herring <robh@kernel.org>
Sandeep Maheswaram [Wed, 1 Apr 2020 05:15:42 +0000 (10:45 +0530)]
dt-bindings: usb: qcom,dwc3: Introduce interconnect properties for Qualcomm DWC3 driver
Add documentation for the interconnects and interconnect-names
properties for USB.
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Geert Uytterhoeven [Thu, 28 May 2020 13:30:33 +0000 (15:30 +0200)]
dt-bindings: timer: renesas: mtu2: Convert to json-schema
Convert the Renesas Multi-Function Timer Pulse Unit 2 (MTU2) Device Tree
binding documentation to json-schema.
Add missing properties.
Update the example to match reality.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Qi Zheng [Thu, 28 May 2020 13:25:41 +0000 (21:25 +0800)]
of/fdt: Remove redundant kbasename function call
For version 1 to 3 of the device tree, this is the node full
path as a zero terminated string, starting with "/". The
following equation will not hold, since the node name has
been processed in the fdt_get_name().
*pathp == '/'
For version 16 and later, this is the node unit name only
(or an empty string for the root node). So the above
equation will still not hold.
So the kbasename() is redundant, just remove it.
Signed-off-by: Qi Zheng <arch0.zheng@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Thu, 28 May 2020 07:27:59 +0000 (15:27 +0800)]
dt-bindings: clock: Convert i.MX1 clock to json-schema
Convert the i.MX1 clock binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Thu, 28 May 2020 07:27:58 +0000 (15:27 +0800)]
dt-bindings: clock: Convert i.MX21 clock to json-schema
Convert the i.MX21 clock binding to DT schema format using json-schema,
can NOT find any CCM interrupt info from reference manual and DT file,
so interrupts property is removed from original binding doc.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Thu, 28 May 2020 07:27:57 +0000 (15:27 +0800)]
dt-bindings: clock: Convert i.MX25 clock to json-schema
Convert the i.MX25 clock binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Thu, 28 May 2020 07:27:56 +0000 (15:27 +0800)]
dt-bindings: clock: Convert i.MX27 clock to json-schema
Convert the i.MX27 clock binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Thu, 28 May 2020 07:27:55 +0000 (15:27 +0800)]
dt-bindings: clock: Convert i.MX23 clock to json-schema
Convert the i.MX23 clock binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Thu, 28 May 2020 07:27:54 +0000 (15:27 +0800)]
dt-bindings: clock: Convert i.MX28 clock to json-schema
Convert the i.MX28 clock binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Thu, 28 May 2020 07:27:53 +0000 (15:27 +0800)]
dt-bindings: clock: Convert i.MX31 clock to json-schema
Convert the i.MX31 clock binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Thu, 28 May 2020 07:27:52 +0000 (15:27 +0800)]
dt-bindings: clock: Convert i.MX35 clock to json-schema
Convert the i.MX35 clock binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Thu, 28 May 2020 07:27:51 +0000 (15:27 +0800)]
dt-bindings: clock: Convert i.MX5 clock to json-schema
Convert the i.MX5 clock binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Jonathan Albrieux [Mon, 25 May 2020 16:46:00 +0000 (18:46 +0200)]
dt-bindings: iio: imu: bmi160: convert format to yaml, add maintainer
Converts documentation from txt format to yaml.
Signed-off-by: Jonathan Albrieux <jonathan.albrieux@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Lad Prabhakar [Sun, 24 May 2020 21:37:54 +0000 (22:37 +0100)]
dt-bindings: usb: usb-xhci: Document r8a7742 support
Document r8a7742 xhci support. The driver will use the fallback
compatible string "renesas,rcar-gen2-xhci", therefore no driver
change is needed.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Lad Prabhakar [Sun, 24 May 2020 21:37:52 +0000 (22:37 +0100)]
dt-bindings: usb: renesas,usbhs: Add support for r8a7742
Document support for RZ/G1H (R8A7742) SoC.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Lad Prabhakar [Sun, 24 May 2020 21:37:51 +0000 (22:37 +0100)]
dt-bindings: PCI: pci-rcar-gen2: Add device tree support for r8a7742
Add internal PCI bridge support for r8a7742 SoC. The Renesas RZ/G1H
(R8A7742) internal PCI bridge is identical to the R-Car Gen2 family.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Lad Prabhakar [Sun, 24 May 2020 21:37:50 +0000 (22:37 +0100)]
dt-bindings: phy: rcar-gen2: Add r8a7742 support
Add USB PHY support for r8a7742 SoC. Renesas RZ/G1H (R8A7742)
USB PHY is identical to the R-Car Gen2 family.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Matthias Brugger [Sat, 23 May 2020 20:15:30 +0000 (22:15 +0200)]
dt-bindings: dma: uart: mtk: fix example
The binding example is missing the fallback compatible.
This is needed as the driver only matches against mt6577.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Lubomir Rintel [Thu, 21 May 2020 09:13:56 +0000 (11:13 +0200)]
dt-bindings: usb: Convert ehci-mv to json-schema
A straightforward conversion of the ehci-mv binding to DT schema format
using json-schema.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
[robh: add unevaluatedProperties]
Signed-off-by: Rob Herring <robh@kernel.org>
Lubomir Rintel [Thu, 21 May 2020 09:13:54 +0000 (11:13 +0200)]
dt-bindings: spi: Convert spi-pxa2xx to json-schema
A straightforward conversion of the the spi-pxa2xx binding to DT schema
format using json-schema.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
[robh: add unevaluatedProperties]
Signed-off-by: Rob Herring <robh@kernel.org>
Lubomir Rintel [Thu, 21 May 2020 09:13:52 +0000 (11:13 +0200)]
dt-bindings: media: Convert marvell,mmp2-ccic to json-schema
Convert the marvell,mmp2-ccic binding to DT schema format using
json-schema. While at that this drops the "func" and "phy" clocks.
The driver consumes clocks with those names, but it's not clear
what are they for and they are not used in DT systems. "phy" is
probably a clock for the sensor and it would belong in the sensor
node.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
[robh: add additionalProperties]
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Wed, 20 May 2020 09:42:17 +0000 (17:42 +0800)]
dt-bindings: thermal: Convert i.MX to json-schema
Convert the i.MX thermal binding to DT schema format using json-schema
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Paul Cercueil [Wed, 20 May 2020 00:22:34 +0000 (02:22 +0200)]
dt-bindings: mtd: Convert ingenic,jz4780-nand.txt to YAML
Convert the ingenic,jz4780-nand.txt doc file to ingenic,nand.yaml.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Rob Herring <robh@kernel.org>
Paul Cercueil [Wed, 20 May 2020 00:22:33 +0000 (02:22 +0200)]
dt-bindings: memory: Convert ingenic,jz4780-nemc.txt to YAML
Convert the ingenic,jz4780-nemc.txt doc file to ingenic,nemc.yaml.
The ingenic,jz4725b-nemc compatible string was added in the process,
with a fallback to ingenic,jz4740-nemc.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Wed, 20 May 2020 00:20:35 +0000 (08:20 +0800)]
dt-bindings: gpio: Convert mxs to json-schema
Convert the MXS GPIO binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Geert Uytterhoeven [Tue, 19 May 2020 08:09:45 +0000 (10:09 +0200)]
dt-bindings: serial: Add renesas,em-uart bindings
Document Device Tree bindings for the Renesas EMMA Mobile UART
Interface.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Rob Herring <robh@kernel.org>
Geert Uytterhoeven [Tue, 19 May 2020 08:08:12 +0000 (10:08 +0200)]
dt-bindings: memory-controllers: renesas,dbsc: Convert to json-schema
Convert the Renesas DDR Bus Controller Device Tree binding documentation
to json-schema.
Drop referrals to driver behavior.
Make power-domains required, as it is present for all current users.
Update the example to match reality.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Geert Uytterhoeven [Tue, 19 May 2020 08:05:19 +0000 (10:05 +0200)]
dt-bindings: interrupt-controller: arm,gic: Document resets property
A generic GIC block embedded in an SoC may be connected to an on-SoC
reset controller. Hence allow the DTS writer to describe this relation,
by documenting the optional presence of a "reset" property.
This gets rid of "make dtbs_check" warnings like:
arch/arm/boot/dts/r8a7791-porter.dt.yaml: interrupt-controller@
f1001000 : 'resets' does not match any of the regexes: '^v2m@[0-9a-f]+$', 'pinctrl-[0-9]+'
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Geert Uytterhoeven [Tue, 19 May 2020 07:58:58 +0000 (09:58 +0200)]
ASoC: fsi: Add missing properties to DT bindings
make dtbs_check:
arch/arm/boot/dts/r8a7740-armadillo800eva.dt.yaml: sound@
fe1f0000 : '#sound-dai-cells', 'clocks', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
Fix this by documenting the missing properties.
Update the example to match reality.
While at it, improve the document title, and comment the various
compatible values with the corresponding SoC names.
Fixes: e56bd85d26ee9053 ("ASoC: fsi: switch to yaml base Documentation")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Geert Uytterhoeven [Tue, 19 May 2020 07:49:53 +0000 (09:49 +0200)]
dt-bindings: rtc: rtc-sh: Add missing power-domains property
make dtbs_check:
arch/arm/boot/dts/r7s72100-rskrza1.dt.yaml: rtc@
fcff1000 : 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
Fix this by documenting the missing power-domains property.
Update the example to match reality.
Fixes: 9b743435a691d406 ("dt-bindings: rtc: rtc-sh: convert bindings to json-schema")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Geert Uytterhoeven [Tue, 19 May 2020 07:42:29 +0000 (09:42 +0200)]
dt-bindings: media: Add missing clock domain description
make dtbs_check:
arch/arm/boot/dts/r7s72100-genmai.dt.yaml: camera@
e8210000 : 'clocks', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
Fix this by documenting the missing properties.
Update the example to match reality.
Fixes: 6e4b9a5c84d7237f ("dt-bindings: media: renesas,ceu: Convert to yaml")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Tue, 19 May 2020 03:55:47 +0000 (11:55 +0800)]
dt-bindings: timer: Convert i.MX SYSCTR to json-schema
Convert the i.MX SYSCTR binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Tue, 19 May 2020 03:55:46 +0000 (11:55 +0800)]
dt-bindings: timer: Convert i.MX TPM to json-schema
Convert the i.MX TPM binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Jonathan McDowell [Mon, 18 May 2020 18:09:31 +0000 (19:09 +0100)]
dt-bindings: vendor-prefixes: Add MikroTik
MikroTik (SIA Mikrotīkls) is a Latvian company who develop routers and
wireless ISP systems.
Signed-off-by: Jonathan McDowell <noodles@earth.li>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Mon, 18 May 2020 14:52:34 +0000 (22:52 +0800)]
dt-bindings: clock: Convert i.MX7D clock to json-schema
Convert the i.MX7D clock binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Mon, 18 May 2020 08:35:57 +0000 (16:35 +0800)]
dt-bindings: interrupt-controller: Convert imx irqsteer to json-schema
Convert the i.MX IRQSTEER binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Lad Prabhakar [Fri, 15 May 2020 15:45:27 +0000 (16:45 +0100)]
dt-bindings: gpio: renesas, rcar-gpio: Add r8a7742 (RZ/G1H) support
Renesas RZ/G1H (R8A7742) SoC GPIO blocks are identical to the R-Car Gen2
family. Add support for its GPIO controllers.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Lad Prabhakar [Fri, 15 May 2020 15:08:54 +0000 (16:08 +0100)]
dt-bindings: power: renesas,apmu: Document r8a7742 support
Document APMU and SMP enable method for RZ/G1H (also known as r8a7742)
SoC.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Lad Prabhakar [Fri, 15 May 2020 15:08:51 +0000 (16:08 +0100)]
dt-bindings: net: renesas,ether: Document R8A7742 SoC
Document RZ/G1H (R8A7742) SoC bindings.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Lad Prabhakar [Fri, 15 May 2020 15:08:50 +0000 (16:08 +0100)]
dt-bindings: net: renesas, ravb: Add support for r8a7742 SoC
Document RZ/G1H (R8A7742) SoC bindings.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Lad Prabhakar [Fri, 15 May 2020 15:08:48 +0000 (16:08 +0100)]
dt-bindings: ata: renesas,rcar-sata: Add r8a7742 support
Document SATA support for the RZ/G1H, which is compatible with
R-Car Gen2 SoC family.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Lad Prabhakar [Fri, 15 May 2020 15:08:42 +0000 (16:08 +0100)]
dt-bindings: i2c: renesas, iic: Document r8a7742 support
Document IIC controller for RZ/G1H (R8A7742) SoC, which is compatible
with R-Car Gen2 SoC family.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Lad Prabhakar [Fri, 15 May 2020 15:08:41 +0000 (16:08 +0100)]
dt-bindings: i2c: renesas, i2c: Document r8a7742 support
Document i2c controller for RZ/G1H (R8A7742) SoC, which is compatible
with R-Car Gen2 SoC family.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Geert Uytterhoeven [Fri, 15 May 2020 13:12:02 +0000 (15:12 +0200)]
dt-bindings: serial: renesas,scifa: Remove part numbers from comments
The conversion to json-schema accidentally retained some SoC part
numbers in comments for compatible values. Drop them, as they're part
of the compatible values anyway.
Fixes: 9665fe856d07fa03 ("dt-bindings: serial: sh-sci: Convert to json-schema")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Lad Prabhakar [Sun, 3 May 2020 21:46:47 +0000 (22:46 +0100)]
dt-bindings: serial: renesas,scifa: Document r8a7742 bindings
RZ/G1H (R8A7742) SoC also has the R-Car gen2 compatible SCIFA ports,
so document the SoC specific bindings.
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Thu, 14 May 2020 11:41:10 +0000 (19:41 +0800)]
dt-bindings: pwm: Convert mxs pwm to json-schema
Convert the mxs pwm binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Geert Uytterhoeven [Thu, 14 May 2020 11:30:02 +0000 (13:30 +0200)]
dt-bindings: auxdisplay: hd44780: Convert to json-schema
Convert the Hitachi HD44780 Character LCD Controller Device Tree binding
documentation to json-schema.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Ricardo Cañuelo [Thu, 14 May 2020 10:12:35 +0000 (12:12 +0200)]
dt-bindings: display: anx7814.txt: convert to yaml
This converts the Analogix ANX7814 bridge DT binding to yaml. Port
definitions and descriptions were expanded, apart from that it's a
direct translation from the original binding.
Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Thu, 14 May 2020 06:54:19 +0000 (14:54 +0800)]
dt-bindings: pwm: Convert imx tpm pwm to json-schema
Convert the imx tpm pwm binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Thu, 14 May 2020 06:54:18 +0000 (14:54 +0800)]
dt-bindings: pwm: Convert imx pwm to json-schema
Convert the imx pwm binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Thu, 14 May 2020 06:13:25 +0000 (14:13 +0800)]
dt-bindings: rtc: Convert MXC RTC V2 to json-schema
Convert the MXC RTC V2 binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Thu, 14 May 2020 06:13:24 +0000 (14:13 +0800)]
dt-bindings: rtc: Convert MXC RTC to json-schema
Convert the MXC RTC binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Niklas Söderlund [Wed, 13 May 2020 15:12:01 +0000 (17:12 +0200)]
dt-bindings: thermal: rcar-gen3-thermal: Convert bindings to json-schema
Convert Renesas R-Car Gen3 Thermal bindings documentation to
json-schema.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Charles Keepax [Wed, 13 May 2020 09:57:20 +0000 (10:57 +0100)]
mfd: madera: Move binding over to dtschema
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
[robh: Drop $ref on *-supply]
Signed-off-by: Rob Herring <robh@kernel.org>
Charles Keepax [Wed, 13 May 2020 09:57:19 +0000 (10:57 +0100)]
pinctrl: madera: Move binding over to dtschema
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Charles Keepax [Wed, 13 May 2020 09:57:18 +0000 (10:57 +0100)]
ASoC: madera: Move binding over to dtschema
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Charles Keepax [Wed, 13 May 2020 09:57:17 +0000 (10:57 +0100)]
mfd: arizona: Move binding over to dtschema
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
[robh: Drop ref from *-supply]
Signed-off-by: Rob Herring <robh@kernel.org>
Charles Keepax [Wed, 13 May 2020 09:57:16 +0000 (10:57 +0100)]
ASoC: arizona: Move binding over to dtschema
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Charles Keepax [Wed, 13 May 2020 09:57:15 +0000 (10:57 +0100)]
extcon: arizona: Move binding over to dtschema
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Charles Keepax [Wed, 13 May 2020 09:57:14 +0000 (10:57 +0100)]
regulator: arizona-regulator: Move binding over to dtschema
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Kunihiko Hayashi [Wed, 13 May 2020 05:42:25 +0000 (14:42 +0900)]
dt-bindings: watchdog: Convert UniPhier watchdog timer to json-schema
Convert UniPhier watchdog timer binding to DT schema format.
Cc: Keiji Hayashibara <hayashibara.keiji@socionext.com>
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Qi Zheng [Sun, 24 May 2020 15:26:14 +0000 (23:26 +0800)]
dt/platform: Fix comment in of_dev_lookup()
The code is using of_dev_lookup() rather than of_devname_lookup().
Signed-off-by: Qi Zheng <arch0.zheng@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Dan Carpenter [Wed, 20 May 2020 12:04:14 +0000 (15:04 +0300)]
of: Fix a refcounting bug in __of_attach_node_sysfs()
The problem in this code is that if kobject_add() fails, then it should
call of_node_put(np) to drop the reference count. I've actually moved
the of_node_get(np) later in the function to avoid needing to do clean
up.
Fixes: 4a3627884aa5 ("of: overlay: add missing of_node_get() in __of_attach_node_sysfs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Charles Keepax [Tue, 12 May 2020 15:23:58 +0000 (16:23 +0100)]
mfd: lochnagar: Move binding over to dtschema
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Charles Keepax [Tue, 12 May 2020 15:23:57 +0000 (16:23 +0100)]
clk: lochnagar: Move binding over to dtschema
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Charles Keepax [Tue, 12 May 2020 15:23:56 +0000 (16:23 +0100)]
pinctrl: lochnagar: Move binding over to dtschema
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Charles Keepax [Tue, 12 May 2020 15:23:55 +0000 (16:23 +0100)]
ASoC: lochnagar: Move binding over to dtschema
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Charles Keepax [Tue, 12 May 2020 15:23:54 +0000 (16:23 +0100)]
hwmon: lochnagar: Move binding over to dtschema
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Lad Prabhakar [Wed, 27 May 2020 16:29:27 +0000 (17:29 +0100)]
dt-bindings: watchdog: renesas,wdt: Document r8a7742 support
RZ/G1H (R8A7742) watchdog implementation is compatible with R-Car Gen2,
therefore add relevant documentation.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Rob Herring <robh@kernel.org>
Nikita Travkin [Mon, 11 May 2020 11:11:26 +0000 (16:11 +0500)]
dt-bindings: vendor-prefixes: Add Shanghai Awinic Technology Co., Ltd.
Add the "awinic" vendor prefix for Shanghai Awinic Technology Co., Ltd.
Website: https://www.awinic.com/
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Nikita Travkin <nikitos.tr@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Wed, 13 May 2020 00:11:24 +0000 (08:11 +0800)]
dt-bindings: clock: Convert i.MX6UL clock to json-schema
Convert the i.MX6UL clock binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Acked-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Wed, 13 May 2020 00:11:23 +0000 (08:11 +0800)]
dt-bindings: clock: Convert i.MX6SLL clock to json-schema
Convert the i.MX6SLL clock binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Acked-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Wed, 13 May 2020 00:11:22 +0000 (08:11 +0800)]
dt-bindings: clock: Convert i.MX6SL clock to json-schema
Convert the i.MX6SL clock binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Acked-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Wed, 13 May 2020 00:11:21 +0000 (08:11 +0800)]
dt-bindings: clock: Convert i.MX6SX clock to json-schema
Convert the i.MX6SX clock binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Acked-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Anson Huang [Wed, 13 May 2020 00:11:20 +0000 (08:11 +0800)]
dt-bindings: clock: Convert i.MX6Q clock to json-schema
Convert the i.MX6Q clock binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Acked-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Sandeep Maheswaram [Thu, 21 May 2020 15:38:19 +0000 (21:08 +0530)]
dt-bindings: usb: qcom,dwc3: Add compatible for SC7180
Add compatible for SC7180 in usb dwc3 bindings.
Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Sandeep Maheswaram [Thu, 21 May 2020 15:38:18 +0000 (21:08 +0530)]
dt-bindings: usb: qcom,dwc3: Convert USB DWC3 bindings
Convert USB DWC3 bindings to DT schema format using json-schema.
Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
[robh: fixup example warnings]
Signed-off-by: Rob Herring <robh@kernel.org>
Etienne Carriere [Tue, 12 May 2020 13:13:34 +0000 (15:13 +0200)]
dt-bindings: nvmem: stm32: new property for data access
Introduce boolean property st,non-secure-otp for OTP data located
in a factory programmed area that only secure firmware can access
by default and that shall be reachable from the non-secure world.
This change also allows additional properties for NVMEM nodes that
were forbidden prior this change.
Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Geert Uytterhoeven [Tue, 12 May 2020 12:24:47 +0000 (14:24 +0200)]
dt-bindings: eeprom: at24: Fix list of page sizes for writing
"258" is an odd power-of-two ;-)
Obviously this is a typo, and the intended value is "256".
Fixes: 297d36ef489710a2 ("dt-bindings: at24: convert the binding document to yaml")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Rob Herring <robh@kernel.org>
chenqiwu [Mon, 11 May 2020 15:04:57 +0000 (23:04 +0800)]
drivers/of: keep description of function consistent with function name
Currently, there are some descriptions of function not
consistent with function name, fixing them will make
the code more readable.
Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Kangmin Park [Sun, 10 May 2020 19:58:21 +0000 (04:58 +0900)]
docs/devicetree/i2c: brcm,bcm2835: fix node id in example
This is a trivial patch to fix node id to match the reg in example.
Signed-off-by: Kangmin Park <l4stpr0gr4m@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Oleksij Rempel [Sun, 10 May 2020 05:15:22 +0000 (07:15 +0200)]
dt-bindings: serial: qca,ar9330-uart: Convert to json-schema
Convert the Qualcomm Atheros AR9330 High-Speed UART
Device Tree binding documentation to json-schema.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Rob Herring <robh@kernel.org>
Andre Przywara [Wed, 13 May 2020 10:30:16 +0000 (11:30 +0100)]
dt-bindings: ehci/ohci: Allow iommus property
A OHCI/EHCI controller could be behind an IOMMU, in which case an iommus
property assigns the stream ID for this device.
Allow that property in the DT bindings to fix a complaint about the Arm Juno
board's DTS file.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Andre Przywara [Wed, 13 May 2020 10:30:15 +0000 (11:30 +0100)]
dt-bindings: mali-midgard: Allow dma-coherent
Add the boolean dma-coherent property to the list of allowed properties,
since some boards (Arm Juno) integrate the GPU this way.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Andre Przywara [Wed, 13 May 2020 10:29:57 +0000 (11:29 +0100)]
dt-bindings: arm: gic: Allow combining arm,gic-400 compatible strings
The arm,gic-400 compatible is probably the best matching string for the
GIC in most modern SoCs, but was only introduced later into the kernel.
For historic reasons and to keep compatibility, some SoC DTs were thus
using a combination of this name and one of the older strings, which
currently the binding denies.
Add a stanza to the DT binding to allow "arm,gic-400", followed by
either "arm,cortex-a15-gic" or "arm,cortex-a7-gic". This fixes binding
compliance for quite some SoC .dtsi files in the kernel tree.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Rob Herring <robh@kernel.org>